linux-kernel - Re: [PATCH 1/2] phy: rcar-gen3-usb2: revise the example of device tree doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 25 Aug 2016 10:29:55 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH 1/2] phy: rcar-gen3-usb2: revise the example of device
 tree doc

Hi Shimoda-san,

On Wed, Aug 24, 2016 at 8:49 AM, Yoshihiro Shimoda
<yoshihiro.shimoda.uh@...esas.com> wrote:
> The clocks property should be set to &cpg, not &mstpX_clks.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

> ---
>  Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
> index 2281d6c..b54fb36 100644
> --- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
> +++ b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
> @@ -30,11 +30,11 @@ Example (R-Car H3):
>                 compatible = "renesas,usb2-phy-r8a7795", "renesas,rcar-gen3-usb2-phy";
>                 reg = <0 0xee080200 0 0x700>;
>                 interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>;
> -               clocks = <&mstp7_clks R8A7795_CLK_EHCI0>;
> +               clocks = <&cpg CPG_MOD 703>;
>         };
>
>         usb-phy@...a0200 {
>                 compatible = "renesas,usb2-phy-r8a7795", "renesas,rcar-gen3-usb2-phy";
>                 reg = <0 0xee0a0200 0 0x700>;
> -               clocks = <&mstp7_clks R8A7795_CLK_EHCI0>;
> +               clocks = <&cpg CPG_MOD 702>;
>         };

BTW, do you want to add #phy-cells and power-domains properties?

BTW2, the actual .dtsi doesn't have the "renesas,rcar-gen3-usb2-phy"
fallback properties.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds