linux-kernel - Re: [RFC PATCH 2/4] perf-probe: Add offline output directory option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 25 Aug 2016 19:48:16 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>, Jiri Olsa <jolsa@...hat.com>
Subject: Re: [RFC PATCH 2/4] perf-probe: Add offline output directory option

On Wed, 24 Aug 2016 09:58:45 -0300
Arnaldo Carvalho de Melo <acme@...nel.org> wrote:

> 
> Also please fix the OPT_STRING string, it should start with a capital
> letter:
> 
>         --max-probes <n>  Set how many probe points can be found for a probe.
>         --no-inlines      Don't search inlined functions
>         --outdir <directory>
>                           path to offline output directory
>         --range           Show variables location range in scope (with --vars only)
> 
> 
> See how it stands out? All the others start with a capital letter.

BTW, actually in most case, perf shows option explanations start without a captal letter,

./perf lock

 Usage: perf lock [<options>] {record|report|script|info}

    -D, --dump-raw-trace  dump raw trace in ASCII
    -i, --input <file>    input file name
    -v, --verbose         be more verbose (show symbol address, etc)

etc. Some commands (including probe) mixing it...

Thanks,

-- 
Masami Hiramatsu <mhiramat@...nel.org>