linux-kernel - Re: [PATCH 4.7 146/186] floppy: fix open(O

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6b0f11af-84a4-ef0c-0033-7a10de189813@compro.net>
Date:   Thu, 25 Aug 2016 09:08:37 -0400
From:   Mark Hounschell <markh@...pro.net>
To:     Jiri Kosina <jikos@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Wim Osterholt <wim@....tudelft.nl>, Jens Axboe <axboe@...com>
Subject: Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only
 open

On 08/24/2016 05:11 PM, Jiri Kosina wrote:
> On Wed, 24 Aug 2016, Greg Kroah-Hartman wrote:
>
>>> I have a problem with this patch. It only fixes one of the regressions
>>> caused by the original change to the floppy driver. It does not address the
>>> user land breakage of removing the NODELAY flag checks.
>>
>> Does the same problem also happen in Linus's tree?  If not, any hints on
>> the patch that might have fixed it there?
>

Yes, it does. IMHO the entire patch (between 4.4 and 4.5 that broke user 
land multiple ways) should be reverted and a fix for what ever obscure 
BUG was supposed to be fixed should be "retried".

> That's still an unresolved issue, and it's on my list to things to look
> into.
>
> This particular patch though fixes a different issue, and should be
> applied to -stable.
>

This patch fixes a bug that was introduced to fix "some other obscure 
BUG" that has nothing to do whatever with the "physical floppy" device. 
And it broke user land in at least 2 ways. All this patch does is revert 
part of the original patch so that it is only broke in 1 way to user 
land. It should revert the whole thing IMHO.

Regards
Mark

> Thanks,
>