linux-kernel - Re: [PATCH] serial: 8250_dw: Check the data->pclk when get apb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1472130612.4887.304.camel@linux.intel.com>
Date:   Thu, 25 Aug 2016 16:10:12 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Kefeng Wang <wangkefeng.wang@...wei.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Chen-Yu Tsai <wens@...e.org>, Jiri Slaby <jslaby@...e.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        guohanjun@...wei.com, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial: 8250_dw: Check the data->pclk when get apb_pclk

On Thu, 2016-08-25 at 15:55 +0300, Andy Shevchenko wrote:
> On Wed, 2016-08-24 at 16:33 +0800, Kefeng Wang wrote:
> > 
> > It should check the data->pclk, not data->clk when get apb_pclk.
> > 
> > Fixes: c8ed99d4f6a8("serial: 8250_dw: Add support for deferred
> > probing")
> > Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>
> 
> pclk is optional on Intel platforms. With your patch we always will
> get
> EPROBE_DEFER that obviously breaks things.

Ah, sorry, it was another culprit.

Tested-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

> 
> > 
> > ---
> >  drivers/tty/serial/8250/8250_dw.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/tty/serial/8250/8250_dw.c
> > b/drivers/tty/serial/8250/8250_dw.c
> > index e199696..b022f5a 100644
> > --- a/drivers/tty/serial/8250/8250_dw.c
> > +++ b/drivers/tty/serial/8250/8250_dw.c
> > @@ -462,7 +462,7 @@ static int dw8250_probe(struct platform_device
> > *pdev)
> >  	}
> >  
> >  	data->pclk = devm_clk_get(&pdev->dev, "apb_pclk");
> > -	if (IS_ERR(data->clk) && PTR_ERR(data->clk) ==
> > -EPROBE_DEFER)
> > {
> > +	if (IS_ERR(data->pclk) && PTR_ERR(data->pclk) ==
> > -EPROBE_DEFER) {
> >  		err = -EPROBE_DEFER;
> >  		goto err_clk;
> >  	}
> 

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy