linux-kernel - [RESEND PATCH 1/1] sched: remove duplicated init_task's preempt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 25 Aug 2016 22:22:21 +0900
From:   "seokhoon.yoon" <iamyooon@...il.com>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     Peter Zijlstra <peterz@...radead.org>, iamyooon@...il.com,
        linux-kernel@...r.kernel.org
Subject: [RESEND PATCH 1/1] sched: remove duplicated init_task's preempt_notifiers init

init_task's preempt_notifiers is initialized at two times.

1) sched_init()
   -> INIT_HLIST_HEAD(&init_task.preempt_notifiers)
2) sched_init()
   -> init_idle(current,) <--- current task is init_task at this time
    -> __sched_fork(,current)
     -> INIT_HLIST_HEAD(&p->preempt_notifiers)

I think first one is needless, remove it.

Signed-off-by: seokhoon.yoon <iamyooon@...il.com>
---
 kernel/sched/core.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 5c883fe..5760f62 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -7482,10 +7482,6 @@ void __init sched_init(void)
 
 	set_load_weight(&init_task);
 
-#ifdef CONFIG_PREEMPT_NOTIFIERS
-	INIT_HLIST_HEAD(&init_task.preempt_notifiers);
-#endif
-
 	/*
 	 * The boot idle thread does lazy MMU switching as well:
 	 */
-- 
1.9.1