linux-kernel - Re: [PATCH 2/2] perf tool: add container identifier entry related changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160825130427.GG10138@twins.programming.kicks-ass.net>
Date:   Thu, 25 Aug 2016 15:04:27 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Hari Bathini <hbathini@...ux.vnet.ibm.com>
Cc:     ast@...com, lkml <linux-kernel@...r.kernel.org>, acme@...nel.org,
        alexander.shishkin@...ux.intel.com, mingo@...hat.com,
        sargun@...gun.me, Aravinda Prasad <aravinda@...ux.vnet.ibm.com>,
        "Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com>,
        Ananth N Mavinakayanahalli <ananth@...ux.vnet.ibm.com>,
        daniel@...earbox.net
Subject: Re: [PATCH 2/2] perf tool: add container identifier entry related
 changes

On Thu, Aug 25, 2016 at 05:28:03PM +0530, Hari Bathini wrote:
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index d9b80ef..d35fbd3 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -929,6 +929,8 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts,
>  	if (opts->sample_transaction)
>  		perf_evsel__set_sample_bit(evsel, TRANSACTION);
>  
> +	perf_evsel__set_sample_bit(evsel, CID);
> +
>  	if (opts->running_time) {
>  		evsel->attr.read_format |=
>  			PERF_FORMAT_TOTAL_TIME_ENABLED |

Does this mean its enabled by default? Why? By growing the default
sample to include everything under the sun we make profiling slower for
everyone.