linux-kernel - Re: [f2fs-dev] [PATCH] f2fs: fix a bug when using namehash to locate dentry bucket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b77fe368-8e6e-3130-1078-b2eb3e2492e4@kernel.org>
Date:   Thu, 25 Aug 2016 22:13:31 +0800
From:   Chao Yu <chao@...nel.org>
To:     Shuoran Liu <liushuoran@...wei.com>, jaegeuk@...nel.org
Cc:     linux-f2fs-devel@...ts.sourceforge.net,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix a bug when using namehash to locate
 dentry bucket

On 2016/8/25 20:42, Shuoran Liu wrote:
> In the following scenario,
> 
> 1) we don't have the key and doing a lookup for encrypted file,
> 2) and the encrypted filename is big name
> 
> we should use fname->hash as name hash value instead of what is
> calculated by fname->disk_name. Because in such case,
> fname->disk_name is empty.

Your signiture is missing here.

Anyway that's a good catch!

Acked-by: Chao Yu <yuchao0@...wei.com>

> ---
>  fs/f2fs/dir.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c
> index 9054aea..b3e6f7f 100644
> --- a/fs/f2fs/dir.c
> +++ b/fs/f2fs/dir.c
> @@ -172,7 +172,10 @@ static struct f2fs_dir_entry *find_in_level(struct inode *dir,
>  	int max_slots;
>  	f2fs_hash_t namehash;
>  
> -	namehash = f2fs_dentry_hash(&name);
> +	if(fname->hash)
> +		namehash = cpu_to_le32(fname->hash);
> +	else
> +		namehash = f2fs_dentry_hash(&name);
>  
>  	nbucket = dir_buckets(level, F2FS_I(dir)->i_dir_level);
>  	nblock = bucket_blocks(level);
>