linux-kernel - Re: [PATCH] arm64: dts: hikey: extend default cma size to 128MB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFGCpxwQLhADWH9aZufgX8YhPF2T-63ZPv1GB6gK8w1dzTzN4w@mail.gmail.com>
Date:   Thu, 25 Aug 2016 10:02:31 +0800
From:   Guodong Xu <guodong.xu@...aro.org>
To:     Rob Herring <robh+dt@...nel.org>
Cc:     Wei Xu <xuwei5@...ilicon.com>,
        Rob Herring <rob.herring@...aro.org>,
        Fathi Boudra <fathi.boudra@...aro.org>,
        John Stultz <john.stultz@...aro.org>,
        Xinliang Liu <xinliang.liu@...aro.org>,
        Mark Rutland <mark.rutland@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Thierry Reding <treding@...dia.com>
Subject: Re: [PATCH] arm64: dts: hikey: extend default cma size to 128MB

On 24 August 2016 at 23:10, Rob Herring <robh+dt@...nel.org> wrote:
> On Wed, Aug 24, 2016 at 8:35 AM, Guodong Xu <guodong.xu@...aro.org> wrote:
>> To support display in Debian on HiKey, cma heap is used to allocate
>> graphic buffers. The default size of CMA is 16 MB which is not enought.
>
> s/enought/enough/
>
>>
>> Increase the default CMA size to 128 MB.
>>
>> cc: Rob Herring <rob.herring@...aro.org>
>> cc: Fathi Boudra <fathi.boudra@...aro.org>
>> cc: John Stultz <john.stultz@...aro.org>
>> cc: Xinliang Liu <xinliang.liu@...aro.org>
>> Signed-off-by: Guodong Xu <guodong.xu@...aro.org>
>> ---
>>  arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
>> index 4a51058..abb3434 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
>> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
>> @@ -45,6 +45,20 @@
>>                       <0x00000000 0x22000000 0x00000000 0x1c000000>;
>>         };
>>
>> +       reserved-memory {
>> +               #address-cells = <2>;
>> +               #size-cells = <2>;
>> +               ranges;
>> +
>> +               /* global autoconfigured region for contiguous allocations */
>> +               linux,cma {
>> +                       compatible = "shared-dma-pool";
>> +                       reusable;
>> +                       size = <0x00000000 0x08000000>;
>> +                       linux,cma-default;
>> +               };
>> +       };
>> +
>>         pstore: pstore@...1f00000 {
>
> So what is upstream (as of 4.8) for ramoops also uses reserved-memory,
> so you should separately fix this.
>

Got it. I will fix and resend.

> Acked-by: Rob Herring <robh@...nel.org>
>

Thanks.
-Guodong


> Rob