linux-kernel - Re: [PATCH 4.7 146/186] floppy: fix open(O

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1d640422-6647-0889-7ac3-501bede1a756@fb.com>
Date:   Thu, 25 Aug 2016 08:57:13 -0600
From:   Jens Axboe <axboe@...com>
To:     Jiri Kosina <jikos@...nel.org>
CC:     <markh@...pro.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-kernel@...r.kernel.org>, <stable@...r.kernel.org>,
        Wim Osterholt <wim@....tudelft.nl>
Subject: Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only
 open

On 08/25/2016 08:53 AM, Jiri Kosina wrote:
> On Thu, 25 Aug 2016, Jens Axboe wrote:
>
>> Which patch is this? If that is truly the case, it should be reverted
>> asap.
>
> I've been looking into this for the past few days, and unfortunately I am
> not able to come up with a simple fix, so revert seems like the way to go.
>
> Unfortunately, by reverting the patch, we'll get back into the original
> situation, where the bug found by syzkaller would be present.
>
> If going down the revert path, we'd have to bring the driver to the state
> it was before, i.e. reverting it and the followup fix, i.e.
>
> 	ff06db1efb2ad6db06eb5b99b88a0c15a9cc9b0e
> 	09954bad448791ef01202351d437abdd9497a804
>
> And then go back to the drawing board to fix the corruption reported by
> syzkaller.

I'll revert these two.

-- 
Jens Axboe