linux-kernel - Re: [PATCH] scsi: not need to alloc zero buffer for local_atto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3abcfebd-8267-e0dd-6594-00ef2f18471a@attotech.com>
Date:   Thu, 25 Aug 2016 14:45:36 -0400
From:   Bradley Grove <bgrove@...otech.com>
To:     Shawn Lin <shawn.lin@...k-chips.com>,
        Bradley Grove <linuxdrivers@...otech.com>,
        jejb@...ux.vnet.ibm.com,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: not need to alloc zero buffer for local_atto_ioctl

Acked-by: Bradley Grove <bgrove@...otech.com>

On 08/20/2016 10:33 PM, Shawn Lin wrote:
> We don't need to use kzalloc as we will always memset the
> local_atto_ioctl later.
>
> Signed-off-by: Shawn Lin <shawn.lin@...k-chips.com>
> ---
>
>  drivers/scsi/esas2r/esas2r_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/esas2r/esas2r_main.c b/drivers/scsi/esas2r/esas2r_main.c
> index 2aca4d1..5092c82 100644
> --- a/drivers/scsi/esas2r/esas2r_main.c
> +++ b/drivers/scsi/esas2r/esas2r_main.c
> @@ -194,7 +194,7 @@ static ssize_t write_hw(struct file *file, struct kobject *kobj,
>  	int length = min(sizeof(struct atto_ioctl), count);
>
>  	if (!a->local_atto_ioctl) {
> -		a->local_atto_ioctl = kzalloc(sizeof(struct atto_ioctl),
> +		a->local_atto_ioctl = kmalloc(sizeof(struct atto_ioctl),
>  					      GFP_KERNEL);
>  		if (a->local_atto_ioctl == NULL) {
>  			esas2r_log(ESAS2R_LOG_WARN,
>

This electronic transmission and any attachments hereto are intended only for the use of the individual or entity to which it is addressed and may contain confidential information belonging to ATTO Technology, Inc. If you have reason to believe that you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution or the taking of any action in reliance on the contents of this electronic transmission is strictly prohibited. If you have reason to believe that you have received this transmission in error, please notify ATTO immediately by return e-mail and delete and destroy this communication.