linux-kernel - Re: [PATCH v2] net: macb: Increase DMA TX buffer size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160825.165906.1864272195425576421.davem@redhat.com>
Date:   Thu, 25 Aug 2016 16:59:06 -0700 (PDT)
From:   David Miller <davem@...hat.com>
To:     xander.huff@...com
Cc:     nicolas.ferre@...el.com, netdev@...r.kernel.org,
        nathan.sullivan@...com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: macb: Increase DMA TX buffer size

From: Xander Huff <xander.huff@...com>
Date: Wed, 24 Aug 2016 17:25:39 -0500

> From: Nathan Sullivan <nathan.sullivan@...com>
> 
> In recent testing with the RT patchset, we have seen cases where the
> transmit ring can fill even with up to 200 txbds in the ring. Increase the
> size of the DMA TX ring to avoid overruns.
> 
> Signed-off-by: Xander Huff <xander.huff@...com>
> Signed-off-by: Nathan Sullivan <nathan.sullivan@...com>

This is really a short term solution.

While a larger TX ring may help RT, it's wasteful to have a ring that
large on non-RT.  Both uses are valid.

Therefore what really needs to happen is to make this driver support
changing the RX and TX ring sizes at runtime via ethtool just like
pretty much every other driver.

THanks.