linux-kernel - Re: [PATCH v2] livepatch/module: make TAINT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1608261442450.22028@cbobk.fhfr.pm>
Date:   Fri, 26 Aug 2016 14:50:48 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
cc:     Jessica Yu <jeyu@...hat.com>, Miroslav Benes <mbenes@...e.cz>,
        Petr Mladek <pmladek@...e.com>, linux-kernel@...r.kernel.org,
        live-patching@...r.kernel.org, Chunyu Hu <chuhu@...hat.com>,
        Rusty Russell <rusty@...tcorp.com.au>
Subject: Re: [PATCH v2] livepatch/module: make TAINT_LIVEPATCH
 module-specific

On Thu, 25 Aug 2016, Josh Poimboeuf wrote:

> There's no reliable way to determine which module tainted the kernel
> with TAINT_LIVEPATCH.  For example, /sys/module/<klp module>/taint
> doesn't report it.  Neither does the "mod -t" command in the crash tool.
> 
> Make it crystal clear who the guilty party is by associating
> TAINT_LIVEPATCH with any module which sets the "livepatch" modinfo
> attribute.  The flag will still get set in the kernel like before, but
> now it also sets the same flag in mod->taint.
> 
> Note that now the taint flag gets set when the module is loaded rather
> than when it's enabled.
> 
> I also renamed find_livepatch_modinfo() to check_modinfo_livepatch() to
> better reflect its purpose: it's basically a livepatch-specific
> sub-function of check_modinfo().
> 
> Reported-by: Chunyu Hu <chuhu@...hat.com>
> Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com>

I've preserved the acks from v1 (*) and applied. Thanks.

(*) Rusty's and Jessica's. If either if you disagrees with that, please 
    let me know

-- 
Jiri Kosina
SUSE Labs