linux-kernel - Re: [PATCH] bug: avoid Kconfig warning for BUG_ON_DATA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160826160823.GF19706@linux.vnet.ibm.com>
Date:   Fri, 26 Aug 2016 09:08:23 -0700
From:   "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:     Rik van Riel <riel@...hat.com>
Cc:     Arnd Bergmann <arnd@...db.de>, Kees Cook <keescook@...omium.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bug: avoid Kconfig warning for BUG_ON_DATA_CORRUPTION

On Fri, Aug 26, 2016 at 11:47:03AM -0400, Rik van Riel wrote:
> On Fri, 2016-08-26 at 17:42 +0200, Arnd Bergmann wrote:
> > The CONFIG_DEBUG_LIST option is normally meant for kernel developers
> > rather than production machines and is guarded by
> > CONFIG_DEBUG_KERNEL.
> > 
> > In contrast, the newly added CONFIG_BUG_ON_DATA_CORRUPTION is meant
> > for security hardening and may be used on systems that intentionally
> > do not enable CONFIG_DEBUG_KERNEL. In this configuration, we get
> > a warning from Kconfig about the mismatched dependencies:
> > 
> > warning: (BUG_ON_DATA_CORRUPTION) selects DEBUG_LIST which has unmet
> > direct dependencies (DEBUG_KERNEL)
> > 
> > This annotates the DEBUG_LIST option to be selectable by
> > BUG_ON_DATA_CORRUPTION when DEBUG_KERNEL is disabled.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > Fixes: 40cd725cfc7f ("bug: Provide toggle for BUG on data
> > corruption")
> > 
> Acked-by: Rik van Riel <riel@...hat.com>

Queued for further review and testing, thank you both!

I expect to push this into the upcoming merge window, given that it
fixes a bug in my current stack of commits.

							Thanx, Paul