linux-kernel - Re: [PATCH 2/2] f2fs: fix to update node page under cp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160826170455.GB88444@jaegeuk>
Date:   Fri, 26 Aug 2016 10:04:55 -0700
From:   Jaegeuk Kim <jaegeuk@...nel.org>
To:     Chao Yu <chao@...nel.org>
Cc:     linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, Chao Yu <yuchao0@...wei.com>
Subject: Re: [PATCH 2/2] f2fs: fix to update node page under cp_rwsem

On Sat, Aug 27, 2016 at 12:14:32AM +0800, Chao Yu wrote:
> From: Chao Yu <yuchao0@...wei.com>
> 
> Update node page under cp_rwsem in order to keep data consistency
> during writting checkpoint.
> 
> Signed-off-by: Chao Yu <yuchao0@...wei.com>
> ---
>  fs/f2fs/inode.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
> index 9ac5efc..1057c73 100644
> --- a/fs/f2fs/inode.c
> +++ b/fs/f2fs/inode.c
> @@ -377,8 +377,11 @@ retry:
>  		goto retry;
>  	}
>  
> -	if (err)
> +	if (err) {
> +		f2fs_lock_op(sbi);
>  		update_inode_page(inode);
> +		f2fs_unlock_op(sbi);
> +	}

Any corner case?
Now, it allows updating node page when checkpoint is doing.

Thanks,

>  	sb_end_intwrite(inode->i_sb);
>  no_delete:
>  	stat_dec_inline_xattr(inode);
> -- 
> 2.7.2