linux-kernel - Re: [PATCH v2] Staging: wlan-ng: replace switch-case statements with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1472234851.4914.51.camel@perches.com>
Date:   Fri, 26 Aug 2016 11:07:31 -0700
From:   Joe Perches <joe@...ches.com>
To:     Claudiu Beznea <claudiu.beznea@...il.com>,
        gregkh@...uxfoundation.org
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Staging: wlan-ng: replace switch-case statements
 with macro

On Fri, 2016-08-26 at 20:58 +0300, Claudiu Beznea wrote:
> This patch removes multiple switch-case statements
> with a new macro. The macro will generate the
> corresponding bit mask based on the key index
> received as input.

Can you go a little farther and remove the
#define DIDmib_dot11smt_dot11WEPDefaultKeysTable_dot11WEPDefaultKey<#>
and uses too?