linux-kernel - Re: [PATCH 2/2] ARM: dts: sun8i: Add extra UART pinmux settings for A23/33

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20160826201842.GB3165@lukather>
Date:   Fri, 26 Aug 2016 22:18:42 +0200
From:   Maxime Ripard <maxime.ripard@...e-electrons.com>
To:     Icenowy Zheng <icenowy@...c.xyz>
Cc:     Russell King <linux@...linux.org.uk>, Chen-Yu Tsai <wens@...e.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH 2/2] ARM: dts: sun8i: Add extra UART pinmux settings for
 A23/33

Hi,

On Tue, Aug 23, 2016 at 09:51:05PM +0800, Icenowy Zheng wrote:
> 
> 
> 23.08.2016, 19:42, "Maxime Ripard" <maxime.ripard@...e-electrons.com>:
> > Hi,
> >
> > On Tue, Aug 23, 2016 at 01:58:26PM +0800, Icenowy Zheng wrote:
> >>  A23/33 have 4 UART controllers outside PRCM. However, the devicetree used
> >>  to mentioned only UART0's pinmux settings. Some extra UART controllers have
> >>  RTS/CTS, and is suitable for using as bluetooth UART controller.
> >>
> >>  Add the pinmux settings for the UART controller, to make use of the
> >>  bluetooth function of some tablets.
> >>
> >>  Signed-off-by: Icenowy Zheng <icenowy@...c.xyz>
> >
> > Our policy is that we avoid adding unused pinctrl nodes to not cripple
> > the DT for no particular reason.
> >
> > So please add only the nodes you'll need in your tablet.
> 
> Then... if what I needs is the PG group of uart1, should I name it as
> uart1_pins_a or uart1_pins_b?

We don't have any rules here, whichever comes first wins.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)