linux-kernel - Re: [PATCH v1 net-next 1/1] fs: gfs2: Check if the return value of rhashtable_walk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+6hz4o_=HQHvRi16VGj04th9Zfcsim0Hj6299WoZfY3-Q2Mvw@mail.gmail.com>
Date:   Fri, 26 Aug 2016 12:49:59 +0800
From:   Feng Gao <gfree.wind@...il.com>
To:     Gao Feng <fgao@...ai8.com>
Cc:     swhiteho@...hat.com, rpeterso@...hat.com, cluster-devel@...hat.com,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 net-next 1/1] fs: gfs2: Check if the return value of
 rhashtable_walk_start is -EAGAIN

On Tue, Aug 23, 2016 at 10:18 PM,  <fgao@...ai8.com> wrote:
> From: Gao Feng <fgao@...ai8.com>
>
> When rhashtable_walk_start returns -EAGAIN, it means the resize event
> happened but the iterator still could be used. So it should not be
> treated as an error in gfs2_glock_seq_start.
>
> Signed-off-by: Gao Feng <fgao@...ai8.com>
> ---
>  fs/gfs2/glock.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
> index 3a90b2b..732721b 100644
> --- a/fs/gfs2/glock.c
> +++ b/fs/gfs2/glock.c
> @@ -1818,7 +1818,7 @@ static void *gfs2_glock_seq_start(struct seq_file *seq, loff_t *pos)
>                 n = (*pos - gi->last_pos);
>
>         ret = rhashtable_walk_start(&gi->hti);
> -       if (ret)
> +       if (ret && ret != -EAGAIN)
>                 return NULL;
>
>         do {
> --
> 1.9.1
>
>

Sorry, this patch should be generated based on linux-gfs2.git.
I will resubmit it, so this one is superseded.

Regards
Feng.