linux-kernel - Re: [PATCH] net: hns: dereference ppe_cb->ppe_common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57BF905D.6050304@huawei.com>
Date:   Fri, 26 Aug 2016 08:42:05 +0800
From:   Yisen Zhuang <Yisen.zhuang@...wei.com>
To:     Colin King <colin.king@...onical.com>,
        Salil Mehta <salil.mehta@...wei.com>,
        "David S . Miller" <davem@...emloft.net>,
        Lisheng <lisheng011@...wei.com>, <netdev@...r.kernel.org>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: hns: dereference ppe_cb->ppe_common_cb if it is
 non-null



在 2016/8/25 14:51, Colin King 写道:
> From: Colin Ian King <colin.king@...onical.com>
> 
> ppe_cb->ppe_common_cb is being dereferenced before a null check is
> being made on it.  If ppe_cb->ppe_common_cb is null then we end up
> with a null pointer dereference when assigning dsaf_dev.  Fix this
> by moving the initialisation of dsaf_dev once we know
> ppe_cb->ppe_common_cb is OK to dereference.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Acked-by: Yisen Zhuang <yisen.zhuang@...wei.com>