[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACRpkdY+XSQHpaTi2KOeP15Hqsaw59G7xFUVGE8umLjvdMV9SA@mail.gmail.com>
Date: Sat, 27 Aug 2016 13:12:18 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Paul Gortmaker <paul.gortmaker@...driver.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Hongzhou Yang <hongzhou.yang@...iatek.com>,
"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH 1/6] pinctrl: mediatek: make mtk-common explicitly non-modular
On Tue, Aug 23, 2016 at 11:19 PM, Paul Gortmaker
<paul.gortmaker@...driver.com> wrote:
> The Makefile currently controlling compilation of this code is:
>
> drivers/pinctrl/mediatek/pinctrl-mtk-common.o
> ---> drivers/pinctrl/mediatek/Makefile:obj-y += pinctrl-mtk-common.o
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the couple traces of modular infrastructure use, so that
> when reading the driver there is no doubt it is builtin-only.
>
> We delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
>
> We don't replace module.h with init.h since the file doesn't need that.
>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Hongzhou Yang <hongzhou.yang@...iatek.com>
> Cc: linux-gpio@...r.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
Patch applied.
Yours,
Linus Walleij
Powered by blists - more mailing lists