linux-kernel - Re: [RFC v4 14/22] clockevents: clockevents_program

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 27 Aug 2016 17:23:18 +0200
From:   Nicolai Stange <nicstange@...il.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     Nicolai Stange <nicstange@...il.com>,
        John Stultz <john.stultz@...aro.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC v4 14/22] clockevents: clockevents_program_event(): turn clc into unsigned long

Thomas Gleixner <tglx@...utronix.de> writes:

> On Tue, 23 Aug 2016, Nicolai Stange wrote:
>
>> Right now, being of type unsigned long long, the clc local variable in
>> clockevents_program_event() is unnecessarily wide as it gets cast to
>> unsigned long anyway.
>
> Congrats! You just broke 32bit systems. When delta is sufficiently large then
> the mult overflows....

The 32bit breakage has been introduced in [13/22] ("clockevents: check a
programmed delta's bounds in terms of cycles") already -- please see my
reply there.