linux-kernel - Re: [PATCH] rtlwifi/rtl8192de: Fix print format string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02432ef7-0e5e-5c83-bde9-6269dabac3b6@lwfinger.net>
Date:   Sat, 27 Aug 2016 21:30:06 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Oleg Drokin <green@...uxhacker.ru>,
        Chaoming Li <chaoming_li@...lsil.com.cn>,
        Kalle Valo <kvalo@...eaurora.org>
Cc:     linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtlwifi/rtl8192de: Fix print format string

On 08/26/2016 10:12 PM, Oleg Drokin wrote:
> %ul was likely meant as %lu to print an unsigned long,
> not an unsigned with a letter l at the end.
> But in fact the value printed is u32 anyway, so just drop
> the l completely.

This patch looks OK, thus

Acked-by: Larry Finger <Larry.Finger@...inger.net>

Thanks,

Larry

>
> Signed-off-by: Oleg Drokin <green@...uxhacker.ru>
> ---
>  drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> index d334d2a..2a4810d 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> @@ -588,7 +588,7 @@ static bool _rtl92d_phy_config_bb_with_headerfile(struct ieee80211_hw *hw,
>  				 * setting. */
>  				udelay(1);
>  				RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,
> -					 "The Rtl819XAGCTAB_Array_Table[0] is %ul Rtl819XPHY_REGArray[1] is %ul\n",
> +					 "The Rtl819XAGCTAB_Array_Table[0] is %u Rtl819XPHY_REGArray[1] is %u\n",
>  					 agctab_array_table[i],
>  					 agctab_array_table[i + 1]);
>  			}
> @@ -604,7 +604,7 @@ static bool _rtl92d_phy_config_bb_with_headerfile(struct ieee80211_hw *hw,
>  					 * setting. */
>  					udelay(1);
>  					RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,
> -						 "The Rtl819XAGCTAB_Array_Table[0] is %ul Rtl819XPHY_REGArray[1] is %ul\n",
> +						 "The Rtl819XAGCTAB_Array_Table[0] is %u Rtl819XPHY_REGArray[1] is %u\n",
>  						 agctab_array_table[i],
>  						 agctab_array_table[i + 1]);
>  				}
> @@ -620,7 +620,7 @@ static bool _rtl92d_phy_config_bb_with_headerfile(struct ieee80211_hw *hw,
>  					 * setting. */
>  					udelay(1);
>  					RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,
> -						 "The Rtl819XAGCTAB_5GArray_Table[0] is %ul Rtl819XPHY_REGArray[1] is %ul\n",
> +						 "The Rtl819XAGCTAB_5GArray_Table[0] is %u Rtl819XPHY_REGArray[1] is %u\n",
>  						 agctab_5garray_table[i],
>  						 agctab_5garray_table[i + 1]);
>  				}
>