linux-kernel - Re: cris-cryptocop: Apply another recommendation from "checkpatch.pl"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b739ce57-5e5c-e9f6-0e4d-966308445867@users.sourceforge.net>
Date:   Sun, 28 Aug 2016 15:22:42 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Julia Lawall <julia.lawall@...6.fr>
Cc:     linux-cris-kernel@...s.com,
        Adam Buchbinder <adam.buchbinder@...il.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Ingo Molnar <mingo@...nel.org>,
        Jesper Nilsson <jesper.nilsson@...s.com>,
        Jiri Kosina <jkosina@...e.cz>,
        Mikael Starvik <starvik@...s.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Paolo Bonzini <pbonzini@...hat.com>, linux-doc@...r.kernel.org
Subject: Re: cris-cryptocop: Apply another recommendation from "checkpatch.pl"

>>> There is plenty of room for at least &(*pj)->iop on the line before.
>>
>> This is true. - Do you prefer an other indentation approach here?
> 
> Very much.  Most of the kernel code puts as much information on a line as
> possible, unless there is a reason to do otherwise.  Then more of the code
> will fit on the screen at one time.

How do you think about to clarify such an implementation detail also
in a document like "CodingStyle"?

Regards,
Markus