linux-kernel - Re: [PATCH 1/5] IA64-IRQ: Use kmalloc_array() in sn_irq_lh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1472409185.26978.100.camel@perches.com>
Date:   Sun, 28 Aug 2016 11:33:05 -0700
From:   Joe Perches <joe@...ches.com>
To:     Julia Lawall <julia.lawall@...6.fr>
Cc:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        linux-ia64@...r.kernel.org, Fenghua Yu <fenghua.yu@...el.com>,
        Tony Luck <tony.luck@...el.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Paolo Bonzini <pbonzini@...hat.com>
Subject: Re: [PATCH 1/5] IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init()

On Sun, 2016-08-28 at 11:28 +0200, Julia Lawall wrote:

> I do think that there is some value in doing similar things in a uniform
> way, using meaningful names, even if in a particular case it doesn't help
> performance or reduce code size.  Even duplicating code could be OK if it
> is not in a critical path and it makes the code overall easier to
> understand.  But if the maintainer prefers the code not to be duplicated,
> then of course it should not be duplicated.

All true too, thanks Julia.

It's all maintainer choice.