linux-kernel - [PATCH v2 3/5] checkkconfigsymbols.py: fix pylint and pep8 warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160828065132.74259-4-valentinrothberg@gmail.com>
Date:   Sun, 28 Aug 2016 08:51:30 +0200
From:   Valentin Rothberg <valentinrothberg@...il.com>
To:     gregkh@...uxfoundation.org
Cc:     linux-kernel@...r.kernel.org,
        Valentin Rothberg <valentinrothberg@...il.com>
Subject: [PATCH v2 3/5] checkkconfigsymbols.py: fix pylint and pep8 warnings

Fix pylint and pep8 warnings to have a consistent syntax and style.

Signed-off-by: Valentin Rothberg <valentinrothberg@...il.com>
---
 scripts/checkkconfigsymbols.py | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/scripts/checkkconfigsymbols.py b/scripts/checkkconfigsymbols.py
index 322c5e817b4c..4111746b5110 100755
--- a/scripts/checkkconfigsymbols.py
+++ b/scripts/checkkconfigsymbols.py
@@ -16,7 +16,6 @@ import signal
 import subprocess
 import sys
 from multiprocessing import Pool, cpu_count
-from subprocess import Popen, PIPE, STDOUT
 
 
 # regex expressions
@@ -118,8 +117,8 @@ def main():
     """Main function of this module."""
     args = parse_options()
 
-    global color
-    color = args.color and sys.stdout.isatty()
+    global COLOR
+    COLOR = args.color and sys.stdout.isatty()
 
     if args.sim and not args.commit and not args.diff:
         sims = find_sims(args.sim, args.ignore)
@@ -160,7 +159,7 @@ def main():
         # report cases that are present for the commit but not before
         for feature in sorted(undefined_b):
             # feature has not been undefined before
-            if not feature in undefined_a:
+            if feature not in undefined_a:
                 files = sorted(undefined_b.get(feature))
                 undefined[feature] = files
             # check if there are new files that reference the undefined feature
@@ -200,21 +199,21 @@ def main():
                     print("\t- %s (\"%s\")" % (yel(commit[0]), commit[1]))
             else:
                 print("\t- no commit found")
-        print()  #  new line
+        print()  # new line
 
 
 def yel(string):
     """
     Color %string yellow.
     """
-    return "\033[33m%s\033[0m" % string if color else string
+    return "\033[33m%s\033[0m" % string if COLOR else string
 
 
 def red(string):
     """
     Color %string red.
     """
-    return "\033[31m%s\033[0m" % string if color else string
+    return "\033[31m%s\033[0m" % string if COLOR else string
 
 
 def execute(cmd):
@@ -261,7 +260,7 @@ def init_worker():
     signal.signal(signal.SIGINT, signal.SIG_IGN)
 
 
-def find_sims(symbol, ignore, defined = []):
+def find_sims(symbol, ignore, defined=[]):
     """Return a list of max. ten Kconfig symbols that are string-similar to
     @symbol."""
     if defined:
@@ -335,7 +334,6 @@ def check_symbols_helper(pool, ignore):
     for res in pool.map(parse_source_files, arglist):
         referenced_features.update(res)
 
-
     # parse kconfig files
     arglist = []
     for part in partition(kconfig_files, cpu_count()):
@@ -389,7 +387,7 @@ def parse_source_file(sfile):
         lines = stream.readlines()
 
     for line in lines:
-        if not "CONFIG_" in line:
+        if "CONFIG_" not in line:
             continue
         features = REGEX_SOURCE_FEATURE.findall(line)
         for feature in features:
-- 
2.9.3