linux-kernel - Re: [PATCH v05 06/72] include/uapi/linux/hsi/cs-protocol.h: include linux/time.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160828070049.GA2831@lakka.kapsi.fi>
Date:   Sun, 28 Aug 2016 10:00:49 +0300
From:   Mikko Rapeli <mikko.rapeli@....fi>
To:     Sebastian Reichel <sre@...nel.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v05 06/72] include/uapi/linux/hsi/cs-protocol.h: include
 linux/time.h

On Mon, Aug 22, 2016 at 10:52:20PM +0200, Sebastian Reichel wrote:
> Hi,
> 
> On Mon, Aug 22, 2016 at 08:32:23PM +0200, Mikko Rapeli wrote:
> > Fixes userspace compilation errors due to missing timespec definition.
> > 
> > Signed-off-by: Mikko Rapeli <mikko.rapeli@....fi>
> > ---
> >  include/uapi/linux/hsi/cs-protocol.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/include/uapi/linux/hsi/cs-protocol.h b/include/uapi/linux/hsi/cs-protocol.h
> > index f153d6e..c8d9f08 100644
> > --- a/include/uapi/linux/hsi/cs-protocol.h
> > +++ b/include/uapi/linux/hsi/cs-protocol.h
> > @@ -26,6 +26,7 @@
> >  
> >  #include <linux/types.h>
> >  #include <linux/ioctl.h>
> > +#include <linux/time.h>
> >  
> >  /* chardev parameters */
> >  #define CS_DEV_FILE_NAME		"/dev/cmt_speech"
> 
> As far as I can see there header file does not use timespec since
> I removed it roughly a year ago.

Yes, your patch 5023a5ca8e144846ec0646554336000abb11e04f fixes also uapi
compilation errors. This patch from me is not needed and even wrong
for the API.

-Mikko