linux-kernel - Re: [PATCH 1/2] power: bq24735-charger: Request status GPIO with initial input setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160829003652.hs4tk7qmvu25mqhb@earth>
Date:   Mon, 29 Aug 2016 02:36:53 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Paul Kocialkowski <contact@...lk.fr>
Cc:     linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org,
        Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
        David Woodhouse <dwmw2@...radead.org>, linux-pm@...r.kernel.org
Subject: Re: [PATCH 1/2] power: bq24735-charger: Request status GPIO with
 initial input setup

Hi,

On Sun, Aug 28, 2016 at 07:34:45PM +0200, Paul Kocialkowski wrote:
> This requests the status GPIO with initial input setup. it is required
> to read the GPIO status at probe time and thus correctly avoid sending
> i2c messages when AC is not plugged.
> 
> When requesting the GPIO without initial input setup, it always reads 0
> which causes probe to fail as it assumes the charger is connected, sends
> i2c messages and fails.

Please convert the driver to devm_gpiod_get instead.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)