linux-kernel - Re: [RESEND PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fupodnd8.fsf@linux.intel.com>
Date:   Mon, 29 Aug 2016 10:51:15 +0300
From:   Felipe Balbi <felipe.balbi@...ux.intel.com>
To:     John Youn <John.Youn@...opsys.com>,
        Randy Li <randy.li@...k-chips.com>,
        John Youn <John.Youn@...opsys.com>,
        Randy Li <ayaka@...lik.info>,
        "linux-usb\@vger.kernel.org" <linux-usb@...r.kernel.org>
Cc:     "mark.rutland\@arm.com" <mark.rutland@....com>,
        "devicetree\@vger.kernel.org" <devicetree@...r.kernel.org>,
        "heiko\@sntech.de" <heiko@...ech.de>,
        "gregkh\@linuxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-rockchip\@lists.infradead.org" 
        <linux-rockchip@...ts.infradead.org>,
        "robh+dt\@kernel.org" <robh+dt@...nel.org>,
        "eddie.cai\@rock-chips.com" <eddie.cai@...k-chips.com>,
        "kishon\@ti.com" <kishon@...com>
Subject: Re: [RESEND PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform


Hi,

John Youn <John.Youn@...opsys.com> writes:

[...]

>>>> +			 */
>>>> +			if (of_device_is_compatible(np, "rockchip,rk3288-usb"))
>>>> +				hsotg->phy->ops->reset(hsotg->phy);
>>>> +
>>>
>>> You should probably check for NULL before calling the reset()
>>> callback.
>> Sure.
>>>
>>> Also, I'd rather see a generic quirk property that you set for your
>>> platform.
>>>
>>> Something like "phy_reset_on_wakeup_quirk".
>> But Rob Herring want me to implied by the SoC specific compatible 
>> string. I agree with him. It is certainly bug in RK3288 platform.
>> It is no found no the other platform.
>
> Ok, I missed that before.
>
> Based on the drivers I'm familiar with (like dwc3), you would
> typically add a "quirk" anyways.
>
> Felipe,
>
> Do you have some policy or preference on this?

if it's not a dwc2-generic feature, then let's do it via compatible
flag, sure. What we don't want is for things like:

if (is_compatible('synopsys') || is_compatible('rockchip') ||
	is_compatible('foobar') ... )

For that, we'd be better of adding a generic quirk flag which several
can use.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (801 bytes)