linux-kernel - Re: [RESEND][PATCH 1/7 v4] Kconfig: Allow k3dma driver to be selected for more then HISI3xx platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160829081553.GB9355@localhost>
Date:   Mon, 29 Aug 2016 13:45:55 +0530
From:   Vinod Koul <vinod.koul@...el.com>
To:     John Stultz <john.stultz@...aro.org>
Cc:     kbuild test robot <lkp@...el.com>, kbuild-all@...org,
        lkml <linux-kernel@...r.kernel.org>,
        Zhangfei Gao <zhangfei.gao@...aro.org>,
        Krzysztof Kozlowski <k.kozlowski@...sung.com>,
        Maxime Ripard <maxime.ripard@...e-electrons.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Mark Brown <broonie@...nel.org>, Andy Green <andy@...mcat.com>
Subject: Re: [RESEND][PATCH 1/7 v4] Kconfig: Allow k3dma driver to be
 selected for more then HISI3xx platforms

On Mon, Aug 22, 2016 at 09:24:42PM -0700, John Stultz wrote:
> On Mon, Aug 22, 2016 at 9:23 PM, kbuild test robot <lkp@...el.com> wrote:
> > Hi John,
> >
> > [auto build test ERROR on linus/master]
> > [also build test ERROR on v4.8-rc3 next-20160822]
> > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> > [Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
> > [Check https://git-scm.com/docs/git-format-patch for more information]
> >
> > url:    https://github.com/0day-ci/linux/commits/John-Stultz/K3DMA-fixes-for-HiKey-HDMI-audio/20160823-070749
> > config: i386-allmodconfig (attached as .config)
> > compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
> > reproduce:
> >         # save the attached .config to linux build tree
> >         make ARCH=i386
> >
> > Note: the linux-review/John-Stultz/K3DMA-fixes-for-HiKey-HDMI-audio/20160823-070749 HEAD 1f1a623a69af65b192d7f6e2949d4a2dcf75d137 builds fine.
> >       It only hurts bisectibility.
> >
> > All errors (new ones prefixed by >>):
> >
> >    drivers/dma/k3dma.c: In function 'k3_dma_prep_memcpy':
> >>> drivers/dma/k3dma.c:432:20: error: implicit declaration of function '__virt_to_phys' [-Werror=implicit-function-declaration]
> >      ds->desc_hw_lli = __virt_to_phys((unsigned long)&ds->desc_hw[0]);
> >                        ^~~~~~~~~~~~~~
> 
> Grumble.. Looks like this is due to COMPILE_TEST being enabled in the
> i386 config and the Kconfig change happening before the fix to remove
> __virt_to_phys from this driver.
> 
> Reordering so the Kconfig change is applied last would avoid this.
> 
> Vinod/Dan: Would you prefer I resend a new patchset with the fixed
> order, or do you mind re-ordering the Kconfig change when you apply?

Yes, prefer a new patchset ...

Thanks
-- 
~Vinod