linux-kernel - Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <57C3EDBE.7060709@linux.vnet.ibm.com>
Date:   Mon, 29 Aug 2016 13:39:34 +0530
From:   Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     linux-kernel@...r.kernel.org, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        mhiramat@...nel.org, wangnan0@...wei.com,
        hemant@...ux.vnet.ibm.com, naveen.n.rao@...ux.vnet.ibm.com,
        Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com>
Subject: Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled
 without optimization



On Saturday 27 August 2016 01:24 AM, Arnaldo Carvalho de Melo wrote:
> Em Fri, Aug 26, 2016 at 04:30:27PM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Wed, Aug 03, 2016 at 02:28:45PM +0530, Ravi Bangoria escreveu:
>>> +++ b/tools/perf/util/probe-finder.c
>>> @@ -892,6 +892,169 @@ static int find_probe_point_lazy(Dwarf_Die *sp_die, struct probe_finder *pf)
>>>  	return die_walk_lines(sp_die, probe_point_lazy_walker, pf);
>>>  }
>>   
>>> +static bool var_has_loclist(Dwarf_Die *die)
>> So, the variable 'die' cause the build to fail in multiple systems, I'm
>> renaming it to 'cu_die', there are some more problems when cross compiling it
>> to some arches, I'm trying to fix them all now:
> Fixed, please check:
>
> http://git.kernel.org/cgit/linux/kernel/git/acme/linux.git/commit/?h=perf/urgent&id=3866e3762da3291613dfb8b193885a8ed3836669

Thanks Arnaldo,

I've tested it. Looks fine to me.

-Ravi

> - Arnaldo
>