linux-kernel - Re: [PATCH v1] usb: gadget: configfs: log function unbinding as information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871t18dmca.fsf@linux.intel.com>
Date:   Mon, 29 Aug 2016 11:13:25 +0300
From:   Felipe Balbi <balbi@...nel.org>
To:     Romain Izard <romain.izard.pro@...il.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Romain Izard <romain.izard.pro@...il.com>
Subject: Re: [PATCH v1] usb: gadget: configfs: log function unbinding as information


Hi,

Romain Izard <romain.izard.pro@...il.com> writes:
> Disabling USB gadget functions configured through configfs is something
> that can happen in normal use cases. Keep the existing log for this type
> of event, but only as information, not as an error.
>
> Signed-off-by: Romain Izard <romain.izard.pro@...il.com>
> ---
>  drivers/usb/gadget/configfs.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
> index 70cf3477f951..11f3a649d9e5 100644
> --- a/drivers/usb/gadget/configfs.c
> +++ b/drivers/usb/gadget/configfs.c
> @@ -1211,8 +1211,9 @@ static void purge_configs_funcs(struct gadget_info *gi)
>  
>  			list_move_tail(&f->list, &cfg->func_list);
>  			if (f->unbind) {
> -				dev_err(&gi->cdev.gadget->dev, "unbind function"
> -						" '%s'/%p\n", f->name, f);
> +				dev_info(&gi->cdev.gadget->dev,

seems to me dev_dbg() is a far better alternative. We really don't need
this on everybody's log buffer unless they really _are_ debugging some
possible issues.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (801 bytes)