linux-kernel - Re: [v4.7.2: Oops] When loading IT87 HARDWARE MONITORING DRIVER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 Aug 2016 12:06:34 +0200
From:   Jean Delvare <jdelvare@...e.de>
To:     Alexander Kapshuk <alexander.kapshuk@...il.com>
Cc:     linux-hwmon@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [v4.7.2: Oops] When loading IT87 HARDWARE MONITORING DRIVER

Hello Alexander,

On Sat, 27 Aug 2016 18:52:42 +0300, Alexander Kapshuk wrote:
> I get an Oops when loading it87.ko on a 4.7.2 kernel. See below for details:

it87_attributes_in lacks its NULL terminator, looks suspicious to me.
Can you try the following quick fix?

---
 drivers/hwmon/it87.c |    1 +
 1 file changed, 1 insertion(+)

--- linux-4.7.orig/drivers/hwmon/it87.c	2016-07-04 08:01:00.000000000 +0200
+++ linux-4.7/drivers/hwmon/it87.c	2016-08-29 12:04:52.926911625 +0200
@@ -2015,6 +2015,7 @@ static struct attribute *it87_attributes
 	&sensor_dev_attr_in10_input.dev_attr.attr,	/* 41 */
 	&sensor_dev_attr_in11_input.dev_attr.attr,	/* 41 */
 	&sensor_dev_attr_in12_input.dev_attr.attr,	/* 41 */
+	NULL
 };
 
 static const struct attribute_group it87_group_in = {

I'm trying to find when the bug was introduced. I have a hard time
believing it went unnoticed for long. If it fixes your problem I'll
send a clean patch.

-- 
Jean Delvare
SUSE L3 Support