linux-kernel - Re: [PATCH] fix:mailbox:bcm-pdc-mailbox:mark symbols static where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <16746903.dkEEJ6ppqu@wuerfel>
Date:   Mon, 29 Aug 2016 12:54:55 +0200
From:   Arnd Bergmann <arnd@...aro.org>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     jassisinghbrar@...il.com, linux-kernel@...r.kernel.org,
        xie.baoyou@....com.cn
Subject: Re: [PATCH] fix:mailbox:bcm-pdc-mailbox:mark symbols static where possible

On Sunday, August 28, 2016 1:15:24 AM CEST Baoyou Xie wrote:
> We get 2 warnings when biuld kernel with W=1:
> drivers/mailbox/bcm-pdc-mailbox.c:472:6: warning: no previous prototype for 'pdc_setup_debugfs' [-Wmissing-prototypes]
> drivers/mailbox/bcm-pdc-mailbox.c:488:6: warning: no previous prototype for 'pdc_free_debugfs' [-Wmissing-prototypes]
> 
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> so this patch marks these functions with 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> 

Acked-by: Arnd Bergmann <arnd@...db.de>