lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 29 Aug 2016 13:09:08 +0200 From: SF Markus Elfring <elfring@...rs.sourceforge.net> To: linuxppc-dev@...ts.ozlabs.org, Adam Buchbinder <adam.buchbinder@...il.com>, Andrew Donnellan <andrew.donnellan@....ibm.com>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Marc Zyngier <marc.zyngier@....com>, Michael Ellerman <mpe@...erman.id.au>, Paul Mackerras <paulus@...ba.org>, Scott Wood <scottwood@...escale.com>, Sudeep Holla <Sudeep.Holla@....com>, Thomas Gleixner <tglx@...utronix.de> Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org, Julia Lawall <julia.lawall@...6.fr>, Paolo Bonzini <pbonzini@...hat.com> Subject: [PATCH 2/5] powerpc-MSI: Use kmalloc_array() in ppc4xx_setup_msi_irqs() From: Markus Elfring <elfring@...rs.sourceforge.net> Date: Mon, 29 Aug 2016 11:11:24 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net> --- arch/powerpc/sysdev/ppc4xx_msi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/sysdev/ppc4xx_msi.c b/arch/powerpc/sysdev/ppc4xx_msi.c index 8fb8061..0bd5e4b 100644 --- a/arch/powerpc/sysdev/ppc4xx_msi.c +++ b/arch/powerpc/sysdev/ppc4xx_msi.c @@ -89,7 +89,9 @@ static int ppc4xx_setup_msi_irqs(struct pci_dev *dev, int nvec, int type) if (type == PCI_CAP_ID_MSIX) pr_debug("ppc4xx msi: MSI-X untested, trying anyway.\n"); - msi_data->msi_virqs = kmalloc((msi_irqs) * sizeof(int), GFP_KERNEL); + msi_data->msi_virqs = kmalloc_array(msi_irqs, + sizeof(*msi_data->msi_virqs), + GFP_KERNEL); if (!msi_data->msi_virqs) return -ENOMEM; -- 2.9.3
Powered by blists - more mailing lists