linux-kernel - Re: [PATCH] acer-wmi: only supports AMW0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160829125520.GC10967@linux-rxt1.site>
Date:   Mon, 29 Aug 2016 20:55:20 +0800
From:   joeyli <jlee@...e.com>
To:     Bjørn Mork <bjorn@...k.no>
Cc:     "Lee, Chun-Yi" <joeyli.kernel@...il.com>,
        Darren Hart <dvhart@...radead.org>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] acer-wmi: only supports AMW0_GUID1 on acer family

Hi Bjørn, 

On Mon, Aug 29, 2016 at 12:11:59PM +0200, Bjørn Mork wrote:
> "Lee, Chun-Yi" <joeyli.kernel@...il.com> writes:
> 
> > The AMW0_GUID1 wmi is not only found on Acer family but also other
> > machines like Lenovo, Fujitsu and Medion. In the past days, acer-wmi
> > driver handled those non-Acer machines by quirks list.
> >
> > But actually acer-wmi driver was loaded on any machines that have
> > AMW0_GUID1. This behavior is strange because those machines should
> > be supported by appropriate wmi drivers. e.g. fujitsu-laptop,
> > ideapad-laptop.
> >
> > So, This patch adds the logic to check the machine that has AMW0_GUID1
> > should be in Acer/Packard Bell/Gateway white list. But, it still keeps
> > the quirk list of those supported non-acer machines for backward
> > compatible.
> 
> Works fine for me on a Lenovo Thinkpad X1 Carbon 4th gen.  Thanks.
> 
> Bogus accelerometer device without patch:
> 
>   acer_wmi: Acer Laptop ACPI-WMI Extras
>   input: Acer BMA150 accelerometer as /devices/virtual/input/input16
> 
> With patch:
> 
>   acer_wmi: Acer Laptop ACPI-WMI Extras
>   acer_wmi: Unsupported machine has AMW0_GUID1, unable to load
> 
> 
> So if you want it:
> 
> Tested-by: Bjørn Mork <bjorn@...k.no>
> 

Thanks for your help for issue report and testing!

Joey Lee