linux-kernel - Re: [RESEND PATCH] ARM: tegra: fix erroneous address in dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <072ef588-f657-e183-9ca8-52264eea1a8a@ramses-pyramidenbau.de>
Date:   Mon, 29 Aug 2016 15:53:36 +0200
From:   Ralf Ramsauer <ralf@...ses-pyramidenbau.de>
To:     Arnd Bergmann <arnd@...db.de>,
        Thierry Reding <thierry.reding@...il.com>
Cc:     arm@...nel.org, Stephen Warren <swarren@...dotorg.org>,
        Alexandre Courbot <gnurou@...il.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org
Subject: Re: [RESEND PATCH] ARM: tegra: fix erroneous address in dts

Hi,

may I poke you again?

Could you please revert this one (b5c86b7 upstream)? It was only
required for 4.7.x where it got already applied.

Thanks
  Ralf

On 08/12/2016 07:26 PM, Ralf Ramsauer wrote:
> On 08/10/2016 10:46 PM, Arnd Bergmann wrote:
>> On Monday, July 18, 2016 11:58:02 AM CEST Thierry Reding wrote:
>>> On Mon, Jul 18, 2016 at 11:46:48AM +0200, Ralf Ramsauer wrote:
>>>> c90bb7b enabled the high speed UARTs of the Jetson TK1. Due to a merge
>>>> quirk, wrong addresses were introduced. Fix it and use the correct
>>>> addresses.
>>>>
>>>> Thierry let me know, that there is another patch (b5896f67ab3c in
>>>> linux-next) in preparation which removes all the '0,' prefixes of unit
>>>> addresses on Tegra124 and is planned to go upstream in 4.8, so
>>>> this patch will get reverted then.
>>>>
>>>> But for the moment, this patch is necessary to fix current misbehaviour.
>>>>
>>>> Fixes: c90bb7b9b9 ("ARM: tegra: Add high speed UARTs to Jetson TK1 device tree")
>>>> Signed-off-by: Ralf Ramsauer <ralf@...ses-pyramidenbau.de>
>>>> Acked-by: Thierry Reding <thierry.reding@...il.com>
>>>> Cc: linux-tegra@...r.kernel.org
>>>> ---
>>>>  arch/arm/boot/dts/tegra124-jetson-tk1.dts | 4 ++--
>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> ARM-SoC maintainers,
>>>
>>> Just to clarify, this is targetted at v4.7 because the offending patch
>>> was merged in v4.7-rc1. If at all possible it'd be great to get this in,
>>> even if this is terribly last minute.
>>>
>>
>> I just notice this was still missing in v4.8-rc1, so I added it to
>> the fixes branch now, with a stable tag for v4.7
> Hi Arnd,
> 
> Ahm - this patch should have only be applied if it would have been
> possible to commit it before the release of v4.7.
> 
> Mainline Patch b5896f6 ("ARM: tegra: Remove commas from unit addresses
> on Tegra124") which was introduced during the merge window of v4.8 makes
> this patch superfluous and introduces the same error again that we
> initially wanted to fix :-)
> 
> This patch is only required for stable v4.7.x.
> 
> I think the best is to revert it on mainline, as long as stabilization
> window is still open.
> 
>   Ralf
>>
>> 	Arnd
>>
>