linux-kernel - Re: [PATCH] mmc: sdhci-msm: Add pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 Aug 2016 16:20:25 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Pramod Gurav <pramod.gurav@...aro.org>
Cc:     Adrian Hunter <adrian.hunter@...el.com>,
        linux-mmc <linux-mmc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: sdhci-msm: Add pm_runtime and system PM support

On 16 June 2016 at 14:35, Pramod Gurav <pramod.gurav@...aro.org> wrote:
> Provides runtime PM callbacks to enable and disable clock resources
> when idle. Also support system PM callbacks to be called during system
> suspend and resume.
>
> Signed-off-by: Pramod Gurav <pramod.gurav@...aro.org>
> ---
>  drivers/mmc/host/sdhci-msm.c | 57 ++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 57 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index 0653fe7..f4394c8 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -18,6 +18,7 @@
>  #include <linux/of_device.h>
>  #include <linux/delay.h>
>  #include <linux/mmc/mmc.h>
> +#include <linux/pm_runtime.h>
>  #include <linux/slab.h>
>
>  #include "sdhci-pltfm.h"
> @@ -549,6 +550,11 @@ static int sdhci_msm_probe(struct platform_device *pdev)
>         if (ret)
>                 goto clk_disable;
>
> +       platform_set_drvdata(pdev, msm_host);
> +
> +       pm_runtime_set_active(&pdev->dev);
> +       pm_runtime_enable(&pdev->dev);

I think you need to move these a bit earlier, before calling sdhci_add_host().

Maybe it's just easier if you look at the sdhci-of-at91.c driver,
which behaves nicely around runtime PM deployment. You can probably
use the very similar code, except the ->runtime_suspend|resume()
callbacks.

And don't forget to deploy runtime PM support in the ->remove()
callback as well, again sdhci-of-at91 is a good reference.

[...]

Kind regards
Uffe