linux-kernel - Re: [Patch v4 9/9] arm64: Update device tree for Layerscape SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 Aug 2016 23:10:57 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Borislav Petkov <bp@...en8.de>
Cc:     York Sun <york.sun@....com>, Mark Rutland <mark.rutland@....com>,
        yangbo lu <yangbo.lu@...escale.com>,
        Liu Gang <Gang.Liu@....com>, morbidrsa@...il.com,
        linux-arm-kernel@...ts.infradead.org,
        Arnd Bergmann <arnd@...db.de>, devicetree@...r.kernel.org,
        Bhupesh Sharma <bhupesh.sharma@...escale.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>, stuart.yoder@....com,
        linux-kernel@...r.kernel.org, oss@...error.net,
        Rob Herring <robh+dt@...nel.org>,
        Rajesh Bhagat <rajesh.bhagat@...escale.com>,
        Olof Johansson <olof@...om.net>,
        Mingkai Hu <Mingkai.Hu@...escale.com>,
        Li Yang <leoli@...escale.com>, Yuan Yao <yao.yuan@....com>,
        linux-edac@...r.kernel.org
Subject: Re: [Patch v4 9/9] arm64: Update device tree for Layerscape SoCs

On Mon, Aug 29, 2016 at 03:51:30PM +0200, Borislav Petkov wrote:
> On Mon, Aug 29, 2016 at 04:33:50PM +0800, Shawn Guo wrote:
> > To avoid potential merge conflicts. 
> 
> Haven't heard of any so far. And I don't see how adding 1 or 2 DT
> entries more per driver is a serious merge conflict.

Yeah, the conflict might be just easy to resolve.  But it's still
annoying when upstream maintainer runs into it often.  Why don't we
avoid it to ease upstream maintainer's life when it's possible?

> 
> > Unless there are hard dependencies like making it compile, avoiding
> > regression or maintaining bisect, patches should go through their
> > established subsystem/architecture tree.
> 
> Well, doh, the driver simply doesn't work. How are people even supposed
> to test the EDAC tree?

People are not supposed to test EDAC tree in this case. linux-next tree
is born for that.

> Why is it even such a big deal if it is acked by the proper maintainers?
> Cross-tree maintainer acking happens all the time. So don't tell me the
> merge conflicts are your big issue with this.

It's not a big deal, and it happens all the time.  But we shouldn't
consider it as a recommended work flow.

> > Luckily.  If there are many patches on architecture DT branch changing
> > the same file, when driver branch and DT branch merges in upstream
> > branch, there will likely be merge conflicts.
> 
> So? There are tools to resolve those. And again, the DT changes for
> EDAC are basically adding blocks so resolving those conflicts should be
> trivial most of the time.

And again, I do not understand why we do so when there is a work flow to
avoid this.

> 
> So no, I don't consider the potential merge conflicts an issue here.

But I do.

If you really like to apply the DTS patch through EDAC tree, go ahead.
But I'm not going to ACK it, because I have an opinion that this merge
path is not really necessary.

Shawn