linux-kernel - Re: [PATCH RFC v3] x86,mm,sched: make lazy TLB mode even lazier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1472484262.32433.95.camel@redhat.com>
Date:   Mon, 29 Aug 2016 11:24:22 -0400
From:   Rik van Riel <riel@...hat.com>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     "H. Peter Anvin" <hpa@...or.com>, serebrin@...gle.com,
        peterz@...radead.org, linux-kernel@...r.kernel.org,
        luto@...nel.org, bp@...e.de, mgorman@...e.de, tglx@...utronix.de,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH RFC v3] x86,mm,sched: make lazy TLB mode even lazier

On Sat, 2016-08-27 at 10:03 +0200, Ingo Molnar wrote:
> * Rik van Riel <riel@...hat.com> wrote:
> 
> > On Thu, 25 Aug 2016 12:42:15 -0700
> > "H. Peter Anvin" <hpa@...or.com> wrote:
> > 
> > > Why grabbing a lock instead of cmpxchg?
> > 
> > ... and some more cleanups later, this might actually be
> > good to merge, assuming it works for Benjamin :)
> > 
> > ---8<---
> 
> LGTM in principle (it's a pretty clever trick!), just some minor
> stylistic nits:

Thanks for the review. I have applied the stylistic nits, and
turned lazy_tlb_can_skip_flush into a big switch statement as
suggested by Linus.

> > +	 */
> > +	for_each_cpu(cpu, cpumask)
> > +		if (lazy_tlb_can_skip_flush(cpu))
> > +			cpumask_clear_cpu(cpu, (struct cpumask
> > *)cpumask);
> 
> Please remove the 'const' from the cpumask type definition instead of
> this ugly 
> cast!

I played around with this on Thursday already, and ran out of
time to clean that up before going to the next talk. This will
be fixed in the next version. 

> I'd also like to wait for the Tested-by from Benjamin as well before
> we can 
> proceeed.

Agreed.

Ben, a new version is coming up real soon.

-- 

All Rights Reversed.
Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)