| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 29 Aug 2016 10:41:08 -0700
From: Joe Perches <joe@...ches.com>
To: Josh Triplett <josh@...htriplett.org>
Cc: Arnd Bergmann <arnd@...db.de>,
ksummit-discuss@...ts.linuxfoundation.org,
Greg KH <gregkh@...uxfoundation.org>,
Sasha Levin <levinsasha928@...il.com>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [Ksummit-discuss] checkkpatch (in)sanity ?
On Mon, 2016-08-29 at 10:16 -0700, Josh Triplett wrote:
> On Mon, Aug 29, 2016 at 05:47:59AM -0700, Joe Perches wrote:
> >
> > I generally don't run it on my own patches, mostly out
> > of possibly misplaced confidence in my own adherence to
> > the nominal kernel style. It sometimes leads to mild
> > regret over things like whitespace defects.
> In the specific case of whitespace defects, does git diff not catch
> those?
>
> For that matter, should we add a .gitattributes file to the kernel
> enabling additional whitespace errors git knows how to catch? git.git
> has such a file.
For reference:
https://git-scm.com/docs/gitattributes
https://git-scm.com/book/en/v2/Customizing-Git-Git-Configuration
and here's the git.git .gitattributes file:
$ cat .gitattributes
* whitespace=!indent,trail,space
*.[ch] whitespace=indent,trail,space diff=cpp
*.sh whitespace=indent,trail,space
Using something like that for kernel git would be a
good idea for trailing whitespace and space before HT.
But aren't those the generic git default options now?
Powered by blists - more mailing lists