linux-kernel - RE: [PATCH V2] ARM: dts: imx6ul iomuxc syscon is compatible to imx6q

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM3PR04MB1315C6AE3AC95A1150DB04D7F5E10@AM3PR04MB1315.eurprd04.prod.outlook.com>
Date:   Mon, 29 Aug 2016 14:44:47 +0000
From:   Yongcai Huang <anson.huang@....com>
To:     Shawn Guo <shawnguo@...nel.org>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>
Subject: RE: [PATCH V2] ARM: dts: imx6ul iomuxc syscon is compatible to imx6q



Best Regards!
Anson Huang



> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@...nel.org]
> Sent: 2016-08-29 10:35 PM
> To: Yongcai Huang <anson.huang@....com>
> Cc: linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
> devicetree@...r.kernel.org; mark.rutland@....com; robh+dt@...nel.org;
> kernel@...gutronix.de; Fabio Estevam <fabio.estevam@....com>;
> linux@...linux.org.uk
> Subject: Re: [PATCH V2] ARM: dts: imx6ul iomuxc syscon is compatible to imx6q
> 
> On Mon, Aug 29, 2016 at 10:25:43PM +0800, Anson Huang wrote:
> > The imx6ul iomuxc syscon is compatible to imx6q, so let's add
> > compatible string 'fsl,imx6q-iomuxc-gpr'
> > for imx6ul iomuxc syscon node.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@....com>
> 
> Will this patch still be needed if you implement imx6ul suspend support with
> PSCI?
> 
> Shawn

This patch is to set the GINT bit for all low power mode transition.

Do we decide to go with PSCI for all i.MX6 SoCs? Currently i.MX6UL's suspend is
already supported with non-PCSI method, only i.MX7D uses PSCI, right? If we decide
to implement all power management feature with PSCI, then yes, all these changes
can be put into PSCI. But since current suspend/cpuidle function are already supported
using old method, this bit must be set to avoid system goes into low power mode
unexpected.

Regards!
Anson.

> 
> > ---
> > changes since V1:
> > 	improve commit message.
> >  arch/arm/boot/dts/imx6ul.dtsi | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/imx6ul.dtsi
> > b/arch/arm/boot/dts/imx6ul.dtsi index 33b95d7..acc9486 100644
> > --- a/arch/arm/boot/dts/imx6ul.dtsi
> > +++ b/arch/arm/boot/dts/imx6ul.dtsi
> > @@ -644,7 +644,8 @@
> >  			};
> >
> >  			gpr: iomuxc-gpr@...e4000 {
> > -				compatible = "fsl,imx6ul-iomuxc-gpr", "syscon";
> > +				compatible = "fsl,imx6ul-iomuxc-gpr",
> > +					     "fsl,imx6q-iomuxc-gpr", "syscon";
> >  				reg = <0x020e4000 0x4000>;
> >  			};
> >
> > --
> > 1.9.1
> >