linux-kernel - Re: [PATCH] iio: magn/ak8974: avoid unused function warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fa26e3e3-aa08-428b-2978-201fb347014f@kernel.org>
Date:   Mon, 29 Aug 2016 19:55:26 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>,
        Linus Walleij <linus.walleij@...aro.org>
Cc:     Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: magn/ak8974: avoid unused function warning

On 26/08/16 16:31, Arnd Bergmann wrote:
> The ak8974_configure() function is used only from the PM code,
> but that can be hidden when CONFIG_PM is disabled:
> 
> drivers/iio/magnetometer/ak8974.c:201:12: error: 'ak8974_configure' defined but not used [-Werror=unused-function]
> 
> This replaces the #ifdef with a __maybe_unused annotation, which
> will work correctly in all configurations and avoid the warning,
> as the compiler can now see where ak8974_configure is called from.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 7c94a8b2ee8c ("iio: magn: add a driver for AK8974")
Applied to the togreg branch of iio.git. Will be initially pushed out
as testing for the autobuilders to play with it.

Thanks,

Jonathan
> ---
>  drivers/iio/magnetometer/ak8974.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/magnetometer/ak8974.c b/drivers/iio/magnetometer/ak8974.c
> index e70e4e22b72c..12bd17b4cf58 100644
> --- a/drivers/iio/magnetometer/ak8974.c
> +++ b/drivers/iio/magnetometer/ak8974.c
> @@ -783,8 +783,7 @@ static int __exit ak8974_remove(struct i2c_client *i2c)
>  	return 0;
>  }
>  
> -#ifdef CONFIG_PM
> -static int ak8974_runtime_suspend(struct device *dev)
> +static int __maybe_unused ak8974_runtime_suspend(struct device *dev)
>  {
>  	struct ak8974 *ak8974 =
>  		iio_priv(i2c_get_clientdata(to_i2c_client(dev)));
> @@ -795,7 +794,7 @@ static int ak8974_runtime_suspend(struct device *dev)
>  	return 0;
>  }
>  
> -static int ak8974_runtime_resume(struct device *dev)
> +static int __maybe_unused ak8974_runtime_resume(struct device *dev)
>  {
>  	struct ak8974 *ak8974 =
>  		iio_priv(i2c_get_clientdata(to_i2c_client(dev)));
> @@ -822,7 +821,6 @@ out_regulator_disable:
>  
>  	return ret;
>  }
> -#endif /* CONFIG_PM */
>  
>  static const struct dev_pm_ops ak8974_dev_pm_ops = {
>  	SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
>