linux-kernel - Re: [PATCH] fix:iio:common:st_sensors:st_sensors_trigger:mark symbols static where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 29 Aug 2016 20:13:49 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Baoyou Xie <baoyou.xie@...aro.org>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>, rob@...nel.org,
        maitysanchayan@...il.com,
        Crestez Dan Leonard <leonard.crestez@...el.com>,
        Gregor Boirie <gregor.boirie@...rot.com>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...aro.org>, xie.baoyou@....com.cn
Subject: Re: [PATCH] fix:iio:common:st_sensors:st_sensors_trigger:mark symbols
 static where possible

On 27/08/16 09:44, Linus Walleij wrote:
> On Sat, Aug 27, 2016 at 8:26 AM, Baoyou Xie <baoyou.xie@...aro.org> wrote:
> 
>> We get 2 warnings when biuld kernel with W=1:
>> drivers/iio/common/st_sensors/st_sensors_trigger.c:69:13: warning: no previous prototype
>> for 'st_sensors_irq_handler' [-Wmissing-prototypes]
>> drivers/iio/common/st_sensors/st_sensors_trigger.c:85:13: warning: no previous prototype
>> for 'st_sensors_irq_thread' [-Wmissing-prototypes]
>>
>> In fact, these functions are only used in the file in which they are
>> declared and don't need a declaration, but can be made static.
>> so this patch marks these functions with 'static'.
>>
>> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> 
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
Applied to the togreg branch of iio.git. Initially pushed out
as testing for the autobuilders to play with it.

Thanks,

Jonathan
> 
> Yours,
> Linus Walleij
>