linux-kernel - Re: [PATCH v2] fix:iio:common:st_sensors:st_sensors_trigger:mark symbols static where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 29 Aug 2016 20:15:22 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Baoyou Xie <baoyou.xie@...aro.org>, lars@...afoo.de,
        pmeerw@...erw.net
Cc:     linus.walleij@...aro.org, rob@...nel.org, maitysanchayan@...il.com,
        leonard.crestez@...el.com, gregor.boirie@...rot.com,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        arnd@...aro.org, xie.baoyou@....com.cn
Subject: Re: [PATCH v2] fix:iio:common:st_sensors:st_sensors_trigger:mark
 symbols static where possible

On 28/08/16 08:04, Baoyou Xie wrote:
> We get 2 warnings when biuld kernel with W=1:
> drivers/iio/common/st_sensors/st_sensors_trigger.c:69:13: warning: no previous prototype
> for 'st_sensors_irq_handler' [-Wmissing-prototypes]
> drivers/iio/common/st_sensors/st_sensors_trigger.c:85:13: warning: no previous prototype
> for 'st_sensors_irq_thread' [-Wmissing-prototypes]
> 
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> so this patch marks these functions with 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
Hi.

Please don't resend just to add Reviewed-by / acked-by tags.
The maintainer will pick those up directly from the mailing list.

If there is anything else different here and I'm missing it you
should have highlighted what it was below the --- and
I'm really being unobservant!

Jonathan
> ---
>  drivers/iio/common/st_sensors/st_sensors_trigger.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/common/st_sensors/st_sensors_trigger.c b/drivers/iio/common/st_sensors/st_sensors_trigger.c
> index e66f12e..fa73e67 100644
> --- a/drivers/iio/common/st_sensors/st_sensors_trigger.c
> +++ b/drivers/iio/common/st_sensors/st_sensors_trigger.c
> @@ -66,7 +66,7 @@ static int st_sensors_new_samples_available(struct iio_dev *indio_dev,
>   * @irq: irq number
>   * @p: private handler data
>   */
> -irqreturn_t st_sensors_irq_handler(int irq, void *p)
> +static irqreturn_t st_sensors_irq_handler(int irq, void *p)
>  {
>  	struct iio_trigger *trig = p;
>  	struct iio_dev *indio_dev = iio_trigger_get_drvdata(trig);
> @@ -82,7 +82,7 @@ irqreturn_t st_sensors_irq_handler(int irq, void *p)
>   * @irq: irq number
>   * @p: private handler data
>   */
> -irqreturn_t st_sensors_irq_thread(int irq, void *p)
> +static irqreturn_t st_sensors_irq_thread(int irq, void *p)
>  {
>  	struct iio_trigger *trig = p;
>  	struct iio_dev *indio_dev = iio_trigger_get_drvdata(trig);
>