linux-kernel - Re: [PATCH] mtd: nand: omap2: Don't call dma_release_channel() if dma_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160829195745.GA99752@google.com>
Date:   Mon, 29 Aug 2016 12:57:45 -0700
From:   Brian Norris <computersforpeace@...il.com>
To:     Boris Brezillon <boris.brezillon@...e-electrons.com>
Cc:     Roger Quadros <rogerq@...com>, dan.carpenter@...cle.com,
        richard@....at, fcooper@...com, linux-mtd@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: nand: omap2: Don't call dma_release_channel() if
 dma_request_chan() failed

On Mon, Aug 15, 2016 at 05:22:00PM +0200, Boris Brezillon wrote:
> On Mon, 15 Aug 2016 10:47:39 +0300
> Roger Quadros <rogerq@...com> wrote:
> 
> > dma_request_chan() can fail returning an error pointer. In this case
> > prevent calling dma_release_channel() to prevent a ERR_PTR() dereference.
> > 
> > As error path can be called even with no DMA configuration, info->dma can
> > be NULL so don't call dma_release_channel() for that case either.
> > 
> > Fixes: de3bfc4a1616: ("mtd: nand: omap2: fix return value check in omap_nand_probe()")
> > Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> > Signed-off-by: Roger Quadros <rogerq@...com>
> 
> Acked-by: Boris Brezillon <boris.brezillon@...e-electrons.com>
> 
> Brian, can you apply this fix directly?

Applied to linux-mtd.git