lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 29 Aug 2016 14:14:11 -0700 From: Brian Norris <briannorris@...omium.org> To: Bjorn Helgaas <bhelgaas@...gle.com> Cc: <linux-kernel@...r.kernel.org>, Brian Norris <computersforpeace@...il.com>, Shawn Lin <shawn.lin@...k-chips.com>, Wenrui Li <wenrui.li@...k-chips.com>, Heiko Stuebner <heiko@...ech.de>, linux-pci@...r.kernel.org, linux-rockchip@...ts.infradead.org, Brian Norris <briannorris@...omium.org> Subject: [PATCH] PCI: rockchip: Correct the register value for clearing client interrupts I'm pretty sure the bitwise 'or' was meant for the value parameter, not the register parameter. This resolves an interrupt storm, where if we receive any client IRQs (e.g., correctable errors), we fail to ever clear them properly, so they reoccur indefinitely. Fixes: 199410f6270e ("PCI: rockchip: Add Rockchip PCIe controller support") Signed-off-by: Brian Norris <briannorris@...omium.org> Cc: Shawn Lin <shawn.lin@...k-chips.com> --- Patched against git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/host-rockchip drivers/pci/host/pcie-rockchip.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c index 8fb47ee9eaee..e77aec3cc869 100644 --- a/drivers/pci/host/pcie-rockchip.c +++ b/drivers/pci/host/pcie-rockchip.c @@ -689,9 +689,10 @@ static irqreturn_t rockchip_pcie_client_irq_handler(int irq, void *arg) PCIE_CLIENT_INT_MSG | PCIE_CLIENT_INT_HOT_RST | PCIE_CLIENT_INT_DPA | PCIE_CLIENT_INT_FATAL_ERR | PCIE_CLIENT_INT_NFATAL_ERR | - PCIE_CLIENT_INT_CORR_ERR), - PCIE_CLIENT_INT_STATUS | - PCIE_CLIENT_INT_PHY); + PCIE_CLIENT_INT_CORR_ERR | + PCIE_CLIENT_INT_PHY), + PCIE_CLIENT_INT_STATUS); + return IRQ_HANDLED; } -- 2.8.0.rc3.226.g39d4020
Powered by blists - more mailing lists