linux-kernel - Re: [RFC 2/3] uprobe: drop isdigit() check in create_trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160829185813.6d044a8e@gandalf.local.home>
Date:   Mon, 29 Aug 2016 18:58:13 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Dmitry Safonov <dsafonov@...tuozzo.com>
Cc:     <linux-kernel@...r.kernel.org>, <mingo@...hat.com>,
        <luto@...capital.net>, <tglx@...utronix.de>, <hpa@...or.com>,
        <x86@...nel.org>, <0x7f454c46@...il.com>, <oleg@...hat.com>,
        <viro@...iv.linux.org.uk>
Subject: Re: [RFC 2/3] uprobe: drop isdigit() check in create_trace_uprobe

On Thu, 25 Aug 2016 18:21:09 +0300
Dmitry Safonov <dsafonov@...tuozzo.com> wrote:

> It's useless. Before:
>   [tracing]# echo 'p:test /a:0x0' >> uprobe_events
>   [tracing]# echo 'p:test a:0x0' >> uprobe_events
>   -bash: echo: write error: No such file or directory
>   [tracing]# echo 'p:test 1:0x0' >> uprobe_events
>   -bash: echo: write error: Invalid argument
> 
> After:
>   [tracing]# echo 'p:test 1:0x0' >> uprobe_events
>   -bash: echo: write error: No such file or directory
> 
> Signed-off-by: Dmitry Safonov <dsafonov@...tuozzo.com>

Acked-by: Steven Rostedt <rostedt@...dmis.org>

-- Steve

> ---
>  kernel/trace/trace_uprobe.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index c53485441c88..a74f2d9ff379 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -427,10 +427,6 @@ static int create_trace_uprobe(int argc, char **argv)
>  		pr_info("Probe point is not specified.\n");
>  		return -EINVAL;
>  	}
> -	if (isdigit(argv[1][0])) {
> -		pr_info("probe point must be have a filename.\n");
> -		return -EINVAL;
> -	}
>  	arg = strchr(argv[1], ':');
>  	if (!arg) {
>  		ret = -EINVAL;