linux-kernel - Re: [PATCH 1/2] tracing/syscalls: allow multiple syscall numbers per syscall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrW1m9ozck-ugX6AKnL7oNA8rvMTjhFGqtVSvKL9BMXMZA@mail.gmail.com>
Date:   Mon, 29 Aug 2016 16:55:27 -0700
From:   Andy Lutomirski <luto@...capital.net>
To:     Marcin Nowakowski <marcin.nowakowski@...tec.com>
Cc:     Linux API <linux-api@...r.kernel.org>, linux-mips@...r.kernel.org,
        Ingo Molnar <mingo@...hat.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] tracing/syscalls: allow multiple syscall numbers per syscall

On Aug 29, 2016 11:30 AM, "Marcin Nowakowski"
<marcin.nowakowski@...tec.com> wrote:
>
> Syscall metadata makes an assumption that only a single syscall number
> corresponds to a given method. This is true for most archs, but
> can break tracing otherwise.
>
> For MIPS platforms, depending on the choice of supported ABIs, up to 3
> system call numbers can correspond to the same call - depending on which
> ABI the userspace app uses.

MIPS isn't special here.  x86 does the same thing.  Why isn't this a
problem on x86?

Also, you seem to be partially reinventing AUDIT_ARCH here.  Can you
use that and integrate with syscall_get_arch()?

--Andy