linux-kernel - Re: [PATCH] printk/nmi: avoid direct printk()-s from __printk_nmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160830010703.GA2200@swordfish>
Date:   Tue, 30 Aug 2016 10:07:03 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:     Petr Mladek <pmladek@...e.com>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Jan Kara <jack@...e.cz>, linux-kernel@...r.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Subject: Re: [PATCH] printk/nmi: avoid direct printk()-s from
 __printk_nmi_flush()

On (08/29/16 17:16), Petr Mladek wrote:
[..]
> The comment above is not longer valid.

oh, yes. it shouldn't even be there.

> > -static void print_nmi_seq_line(struct nmi_seq_buf *s, int start, int end)
> > +static void __print_nmi_seq_line(const char *text, int len)
> 
> Also the name of the function might be confusing because it is not
> longer used only for the seq buffer. I would rename it to
> something like:
> 
>        printk_nmi_flush_line()

sounds good.

> > +static void print_nmi_seq_line(struct nmi_seq_buf *s, int start, int end)
> > +{
> 
> Then I would rename also this function to something like:
> 
>      printk_nmi_flush_seq_line()

sounds good.

> > +	const char *buf = s->buffer + start;
> > +
> > +	__print_nmi_seq_line(buf, (end - start) + 1);
> > +}
> > +
> 
> Othrewise, it looks fine. With the above suggested changes, feel
> free to add:
> 
> Reviewed-by: Petr Mladek <pmladek@...e.com>

thanks, will re-spin today.

	-ss