linux-kernel - Re: [PATCH] bluetooth, regression: MSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABBYNZLtFB9HWXs_Z+CsHJ9pP=NZ_rm8bhx5ng5Cu_LtHJu2kA@mail.gmail.com>
Date:   Tue, 30 Aug 2016 11:23:30 +0300
From:   Luiz Augusto von Dentz <luiz.dentz@...il.com>
To:     Mika Penttilä <mika.penttila@...tfour.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        "linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>
Subject: Re: [PATCH] bluetooth, regression: MSG_TRUNC fixes

Hi Mika,

On Wed, Aug 24, 2016 at 1:13 PM, Mika Penttilä
<mika.penttila@...tfour.com> wrote:
> Recent 4.8-rc changes to bluetooth MSG_TRUNC handling introduced regression; pairing finishes
> but connecting profiles not.
>
> With the below fixes to MSG_TRUNC handling the connection is established normally.
>
> --Mika
>
>
> Signed-off-by: Mika Penttilä <mika.penttila@...tfour.com>
> ---
>
> diff --git a/net/bluetooth/af_bluetooth.c b/net/bluetooth/af_bluetooth.c
> index ece45e0..0b5f729 100644
> --- a/net/bluetooth/af_bluetooth.c
> +++ b/net/bluetooth/af_bluetooth.c
> @@ -250,7 +250,7 @@ int bt_sock_recvmsg(struct socket *sock, struct msghdr *msg, siz
>
>         skb_free_datagram(sk, skb);
>
> -       if (msg->msg_flags & MSG_TRUNC)
> +       if (flags & MSG_TRUNC)
>                 copied = skblen;
>
>         return err ? : copied;
> diff --git a/net/bluetooth/hci_sock.c b/net/bluetooth/hci_sock.c
> index 6ef8a01..96f04b7 100644
> --- a/net/bluetooth/hci_sock.c
> +++ b/net/bluetooth/hci_sock.c
> @@ -1091,7 +1091,7 @@ static int hci_sock_recvmsg(struct socket *sock, struct msghdr
>
>         skb_free_datagram(sk, skb);
>
> -       if (msg->msg_flags & MSG_TRUNC)
> +       if (flags & MSG_TRUNC)
>                 copied = skblen;
>
>         return err ? : copied;
> --

I believe similar patches already went to bluetooth-next so it should
be in the way if not already merged.

-- 
Luiz Augusto von Dentz