linux-kernel - Re: [PATCH][v8] PM / hibernate: Verify the consistent of e820 memory map by md5 value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4046257.PxhXCrvGHl@vostro.rjw.lan>
Date:   Tue, 30 Aug 2016 13:51:19 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Pavel Machek <pavel@....cz>, Chen Yu <yu.c.chen@...el.com>,
        linux-pm@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        linux-kernel@...r.kernel.org, Lee@...gul.tnic,
        Chun-Yi <jlee@...e.com>
Subject: Re: [PATCH][v8] PM / hibernate: Verify the consistent of e820 memory map by md5 value

On Monday, August 29, 2016 03:41:23 PM Borislav Petkov wrote:
> On Mon, Aug 29, 2016 at 09:15:00AM +0200, Pavel Machek wrote:
> > Sounds about as easy as hot unplugging arbitrary memory address. IOW
> > "not easy".
> 
> Regardless, forcibly panicking the system more is still the wrong
> approach IMO.

Agreed.

> Instead, I'd try to issue a big fat warning that BIOS corrupts E820 and
> that the user should disable hibernation on that box and never ever
> enable it again.
> 
> After that, the kernel should *disable* hibernation for the current boot
> so any further hibernation runs don't even happen. Maybe even taint
> itself.

Yes, taint the kernel when e820 mismatch is detected.

It may be a good idea to start an emergency shutdown in that case too, but
after getting to a point when it actually has a chance to work.

Thanks,
Rafael